[webkit-reviews] review granted: [Bug 108108] SVGImage::drawSVGToImageBuffer can combine zoom and scale. : [Attachment 185061] First pass at a single zoomAndScale parameter

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 11:38:25 PST 2013


Tim Horton <timothy_horton at apple.com> has granted Philip Rogers
<pdr at google.com>'s request for review:
Bug 108108: SVGImage::drawSVGToImageBuffer can combine zoom and scale.
https://bugs.webkit.org/show_bug.cgi?id=108108

Attachment 185061: First pass at a single zoomAndScale parameter
https://bugs.webkit.org/attachment.cgi?id=185061&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185061&action=review


Seems reasonable to me!

> Source/WebCore/svg/graphics/SVGImageCache.cpp:107
> +	   imageSize.setWidth(scale * sizeAndScales.size.width());
> +	   imageSize.setHeight(scale * sizeAndScales.size.height());

imageSize = sizeAndScales.size;
imageSize.scale(scale);

Maybe?


More information about the webkit-reviews mailing list