[webkit-reviews] review denied: [Bug 107692] [Curl] There is no way for a WebKit client to set the Curl cookie jar path : [Attachment 185502] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied peavo at outlook.com's request for
review:
Bug 107692: [Curl] There is no way for a WebKit client to set the Curl cookie
jar path
https://bugs.webkit.org/show_bug.cgi?id=107692

Attachment 185502: Patch
https://bugs.webkit.org/attachment.cgi?id=185502&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185502&action=review


Thanks for working on this.  I think it would be cleaner if you encapsulated
this in a helper function (like I did with the "certificatePath").  Then we can
provide port-specific logic for identifying where the cookie jar should live.

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:122
> +    , m_cookieJarFileName("cookies.dat")

I would prefer you write a helper function like "certificatePath" that
encapsulates the identification of this cook jar.

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:137
> +	   m_cookieJarFileName = fastStrDup(cookieJarPath);

This logic should go in the helper function.  Then I can add a CF-variant
without cluttering the code.