[webkit-reviews] review denied: [Bug 107837] [Coordinated Graphics] requestAnimationFrame should trigger a layer flush in the web process : [Attachment 184531] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 09:34:22 PST 2013


Balazs Kelemen <kbalazs at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 107837: [Coordinated Graphics] requestAnimationFrame should trigger a layer
flush in the web process
https://bugs.webkit.org/show_bug.cgi?id=107837

Attachment 184531: Patch
https://bugs.webkit.org/attachment.cgi?id=184531&action=review

------- Additional Comments from Balazs Kelemen <kbalazs at webkit.org>
I realized that this patch is wrong. It can result in endless layer flushing in
the web process if the animation callback does not actually do any layout
change, like an fps counter callback. The current implementation does not
suffer from this.
Actually my problem with the current design was that if I have such an fps
counter, it will count the number of times we repaint in the UI process, and
not the number of synchronized frames. I will try to find another way to fix
this.


More information about the webkit-reviews mailing list