[webkit-reviews] review granted: [Bug 108313] Web Inspector: migrate file selection dialog to the viewport. : [Attachment 185441] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 108313: Web Inspector: migrate file selection dialog to the viewport.
https://bugs.webkit.org/show_bug.cgi?id=108313

Attachment 185441: Patch
https://bugs.webkit.org/attachment.cgi?id=185441&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185441&action=review


> Source/WebCore/ChangeLog:66
> +	   (WebInspector.ViewportControl.Provider.protowarning: LF will be
replaced by CRLF in Source/WebCore/WebCore.vcproj/WebCore.vcproj.

Is that fine?

> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:544
> +	   setTimeout(function() { this._uiSourceCodes.sort(compareFunction);
}.bind(this), 0);

setTimeout(this._uiSourceCodes.sort.bind(this._uiSourceCodes, compareFunction),
0);