[webkit-reviews] review denied: [Bug 107813] Web Inspector: Filters on Console panel : [Attachment 185237] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 03:25:26 PST 2013


Pavel Feldman <pfeldman at chromium.org> has denied Dmitry Zvorygin
<zvorygin at chromium.org>'s request for review:
Bug 107813: Web Inspector: Filters on Console panel
https://bugs.webkit.org/show_bug.cgi?id=107813

Attachment 185237: Patch
https://bugs.webkit.org/attachment.cgi?id=185237&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185237&action=review


Almost good to go.

> Source/WebCore/inspector/front-end/ContextMenu.js:64
> +    get disabled()

Please do not use getters and setters. setEnabled: function(enabled)


More information about the webkit-reviews mailing list