[webkit-reviews] review denied: [Bug 107883] Web Inspector: Add support for handling modal dialogs : [Attachment 185385] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 30 03:21:46 PST 2013
Pavel Feldman <pfeldman at chromium.org> has denied Ken Kania
<kkania at chromium.org>'s request for review:
Bug 107883: Web Inspector: Add support for handling modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=107883
Attachment 185385: Patch
https://bugs.webkit.org/attachment.cgi?id=185385&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
New test fails on Mac EWS. You should file a bug requesting that mac port
implements client hook and disable the test on non-chromium ports.
Implementation-wise, it looks good.
More information about the webkit-reviews
mailing list