[webkit-reviews] review granted: [Bug 107397] [Efl][WebGL] Add better support to track and free XResources. : [Attachment 185079] patchv6

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 03:15:03 PST 2013


Noam Rosenthal <noam at webkit.org> has granted Kalyan
<kalyan.kondapally at intel.com>'s request for review:
Bug 107397: [Efl][WebGL] Add better support to track and free XResources.
https://bugs.webkit.org/show_bug.cgi?id=107397

Attachment 185079: patchv6
https://bugs.webkit.org/attachment.cgi?id=185079&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185079&action=review


> Source/WebCore/ChangeLog:8
> +	   We leak Memory during config selection as we dont free temp

temp -> temporary

> Source/WebCore/ChangeLog:35
> +	   Calls XFree on pointer to memory allocated by X when the class goes
out of scope.

Add some short explanation on why this was needed rather than using OwnPtr.


More information about the webkit-reviews mailing list