[webkit-reviews] review granted: [Bug 108283] REGRESSION (r139282): Caret repainting is broken for text-align: center'd <input> : [Attachment 185442] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Tien-Ren Chen
<trchen at chromium.org>'s request for review:
Bug 108283: REGRESSION (r139282): Caret repainting is broken for text-align:
center'd <input>
https://bugs.webkit.org/show_bug.cgi?id=108283

Attachment 185442: Patch
https://bugs.webkit.org/attachment.cgi?id=185442&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185442&action=review


> Source/WebCore/editing/FrameSelection.cpp:1330
> +    // FIXME: Need to over-paint 1 pixel to workaround some rounding
problem.

s/some/a/ or s/problem/problems/.

> Source/WebCore/editing/FrameSelection.cpp:1332
> +    // Can't reproduce http://webkit.org/b/19086 but probably the same root
cause.

This line doesn't belong here.