[webkit-reviews] review granted: [Bug 107684] On Linux, can't get spelling suggestions without selection when unified text checker is enabled : [Attachment 184751] proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 107684: On Linux, can't get spelling suggestions without selection when
unified text checker is enabled
https://bugs.webkit.org/show_bug.cgi?id=107684

Attachment 184751: proposed patch
https://bugs.webkit.org/attachment.cgi?id=184751&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184751&action=review


> Source/WebCore/editing/Editor.cpp:1781
>	   if (!range)
>	       return Vector<String>();

I would prefer moving this to after if, and then called
frame()->selection()->toNormalizedRange() in the else clause.

> Source/WebCore/editing/Editor.cpp:1783
> +	       VisibleSelection wordSelection(frame()->selection()->base());

wordSelection = frame()->selection()->base() ?

> Source/WebCore/editing/Editor.cpp:1786
> +	       ASSERT(range);

I don’t think we can assert that range is always non-null.