[webkit-reviews] review granted: [Bug 108279] webdatabase: Introducing WTF::TypeSafeEnum and DatabaseError : [Attachment 185386] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 108279: webdatabase: Introducing WTF::TypeSafeEnum and DatabaseError
https://bugs.webkit.org/show_bug.cgi?id=108279

Attachment 185386: the patch.
https://bugs.webkit.org/attachment.cgi?id=185386&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185386&action=review


r=me

> Source/WTF/wtf/TypeSafeEnum.h:51
> +//	  MyEnum value1; // value1 is assigned MyEnum::VALUE_DEFAULT by
default.

Typo: MyEnumDef.

> Source/WebCore/Modules/webdatabase/DatabaseError.h:35
> +struct DatabaseErrorDef {

We don't usually use abbreviations like "Def". How about calling this
"DatabaseErrorStruct" or "DatabaseErrorDefinition"?