[webkit-reviews] review denied: [Bug 108118] RenderLayer hasVisibleContent() has inconsistent semantics causing disappearing composited layers : [Attachment 185341] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 108118: RenderLayer hasVisibleContent() has inconsistent semantics causing
disappearing composited layers
https://bugs.webkit.org/show_bug.cgi?id=108118

Attachment 185341: Patch
https://bugs.webkit.org/attachment.cgi?id=185341&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185341&action=review


> Source/WebCore/rendering/RenderLayerBacking.cpp:1433
> -    // FIXME: We shouldn't be called with a stale z-order lists. See bug
85512.
> -    m_owningLayer->updateLayerListsIfNeeded();
> -
> -#if !ASSERT_DISABLED
> -    LayerListMutationDetector mutationChecker(m_owningLayer);
> -#endif
> -
> -    if (Vector<RenderLayer*>* normalFlowList =
m_owningLayer->normalFlowList()) {
> +    // Common case: Check the layer lists for any children that have visible
content.
> +    if (Vector<RenderLayer*>* normalFlowList = parent->normalFlowList()) {

I think you should early return based on !hasVisibleDescendant() and remove the
hasVisibleDescendant() checks elsewhere. You're missing the
hasVisibleDescendant() on the starting layer.