[webkit-reviews] review granted: [Bug 103558] Allow clients to ask for the WebView/WKView placeholder view when in full screen mode. : [Attachment 176563] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 103558: Allow clients to ask for the WebView/WKView placeholder view when
in full screen mode.
https://bugs.webkit.org/show_bug.cgi?id=103558

Attachment 176563: Patch
https://bugs.webkit.org/attachment.cgi?id=176563&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176563&action=review


This is very unfortunate, but I don't see a cleaner solution, especially for
WebKit1. :(

For WebKit2, IMHO, we should keep the same NSView in place, and use a new view
to present the content in fullscreen. Since the WebKit layer is disconnected
from the NSView, we can theoretically move the backend to a new view.

> Source/WebKit/mac/ChangeLog:4
> +	   Allow clients to ask for the WebView/WKView placeholder view when in
full screen mode.
> +	   https://bugs.webkit.org/show_bug.cgi?id=103558

It would be good to provide the radar number in the ChangeLog for future
reference. This radar is pretty good.