[webkit-reviews] review denied: [Bug 107701] Canvas and DOM go out of sync : [Attachment 185271] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 29 11:25:28 PST 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied sugoi at chromium.org's
request for review:
Bug 107701: Canvas and DOM go out of sync
https://bugs.webkit.org/show_bug.cgi?id=107701

Attachment 185271: Patch
https://bugs.webkit.org/attachment.cgi?id=185271&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185271&action=review


> Source/WebCore/page/FrameView.cpp:1256
> +    if (subtree && positionChanged) {
> +	   RenderObject* topRoot = document->renderer();
> +	   if (topRoot) {
> +	       RenderLayer* topLayer = topRoot->enclosingLayer();
> +	      
topLayer->updateLayerPositionsAfterLayout(rootRenderer(this)->layer(),
> +		   updateLayerPositionFlags(topLayer, false, m_doFullRepaint));

> +	   }
> +    }

This doesnt' seem compositing-related. We rely on RenderLayer positions for
invalidation etc too.


More information about the webkit-reviews mailing list