[webkit-reviews] review granted: [Bug 104924] [Chromium] Fix find in page rects for overflowing content. : [Attachment 185259] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 104924: [Chromium] Fix find in page rects for overflowing content.
https://bugs.webkit.org/show_bug.cgi?id=104924

Attachment 185259: Patch
https://bugs.webkit.org/attachment.cgi?id=185259&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185259&action=review


If you want your change to be committed, you should ask for the commit-queue
flag (cq?). I don't need to see the next iteration (ie you can carry over my r+
to the new patch).

> Source/WebKit/chromium/ChangeLog:19
> +	   * src/FindInPageCoordinates.cpp:
> +	   (WebKit::enclosingScrollableAncestor):
> +	   (WebKit::toNormalizedRect):
> +	   (WebKit::findInPageRectFromAbsoluteRect):
> +	   * tests/WebFrameTest.cpp:
> +	   * tests/data/find.html:
> +	   * tests/data/find_in_page_frame.html:

What I meant is that I prefer the ChangeLog to include some low-level details
here about the exact change. For example for the first entry above:

(WebKit::enclosingScrollableAncestor):
Helper function to find the enclosing containing block with an overflow clip.