[webkit-reviews] review granted: [Bug 104924] [Chromium] Fix find in page rects for overflowing content. : [Attachment 185240] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 104924: [Chromium] Fix find in page rects for overflowing content.
https://bugs.webkit.org/show_bug.cgi?id=104924

Attachment 185240: Patch
https://bugs.webkit.org/attachment.cgi?id=185240&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185240&action=review


> Source/WebKit/chromium/ChangeLog:15
> +	   (WebKit):

Let's remove this useless entry and fill in the other ChangeLog function
entries.

> Source/WebKit/chromium/src/FindInPageCoordinates.cpp:53
> +{

If you assume that this function shouldn't be called on the RenderView, you
should add ASSERT(!renderer->isRenderView()) here.

> Source/WebKit/chromium/src/FindInPageCoordinates.cpp:-114
> -	   ASSERT(renderer->isRenderView());

I still think this ASSERT is valuable (even if you are guaranteed not to hit
it). It insures that you don't forget any renderer when walking up the tree as
jumping to renderer->frame()->ownerRenderer() could skip part of the tree.