[webkit-reviews] review granted: [Bug 107951] Web Inspector: [Canvas] support instrumenting canvases in iframes (backend side) : [Attachment 184972] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 107951: Web Inspector: [Canvas] support instrumenting canvases in iframes
(backend side)
https://bugs.webkit.org/show_bug.cgi?id=107951

Attachment 184972: Patch
https://bugs.webkit.org/attachment.cgi?id=184972&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184972&action=review


>>>>> Source/WebCore/inspector/InspectorCanvasAgent.cpp:284
>>>>>	   ScriptProfiler::visitNodeWrappers(&nodeVisitor);
>>>> 
>>>> What are you trying to do here? You should not depend on profiler. Do you
want to traverse frame tree and collect all the canvases using
querySelectorAll?
>>> 
>>> I want those canvases as well as ones that are not attached to the DOM tree
(yet).
>> 
>> Why would you want that?
> 
> 1) To instrument canvases that are not in the DOM. It's quite common to
create a temp canvas to render some part of the scene and then discard it.
> 
> 2) To handle the case when we would enable CanvasAgent between a canvas
context is created and it is appended to the DOM.

Iterating over bindings to achieve that sounds like an overkill. It is a shame
we need to do that.