[webkit-reviews] review denied: [Bug 107441] Web Inspector: [Network] Add cookie column to show presence of request/response cookies. : [Attachment 185184] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 107441: Web Inspector: [Network] Add cookie column to show presence of
request/response cookies.
https://bugs.webkit.org/show_bug.cgi?id=107441

Attachment 185184: Patch
https://bugs.webkit.org/attachment.cgi?id=185184&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185184&action=review


Please provide a screenshot. r- for unclear sorting.

> Source/WebCore/inspector/front-end/NetworkPanel.js:2228
> +	   var responseCookies = this._request.responseCookies;

What about bidirectional arrow for the case or receive / send? Like U+21D0,
U+21D2, U+21D4 (see http://en.wikipedia.org/wiki/Template:Unicode_chart_Arrows)


> Source/WebCore/inspector/front-end/NetworkPanel.js:2230
> +	       value.push("\u25BC");

// Down triangle

> Source/WebCore/inspector/front-end/NetworkPanel.js:2235
> +	       value.push("\u25B2");

// Up triangle

> Source/WebCore/inspector/front-end/NetworkPanel.js:2414
> +    var aScore = (a._request.responseCookies &&
a._request.responseCookies.length) ? 2 : 0;

I'd rather sort in the following manner: first sort by set-cookie, then sort by
cookie, then the rest.