[webkit-reviews] review denied: [Bug 108161] Web Inspector: introduce HighlightDescriptor interface in DTE. : [Attachment 185185] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 108161: Web Inspector: introduce HighlightDescriptor interface in DTE.
https://bugs.webkit.org/show_bug.cgi?id=108161

Attachment 185185: Patch
https://bugs.webkit.org/attachment.cgi?id=185185&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185185&action=review


> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1379
> +	   this._highlightDescriptors[regex] = highlightDescriptor;

Now you should simply store it in the array.

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1389
> +	   var result = delete this._highlightDescriptors[regex];

... and remove it by instance.

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2661
> +    testLine: function(lineNumber, line) { return false; },

Consider renaming - I can't tell what it does from its name.