[webkit-reviews] review granted: [Bug 108077] [HarfBuzz] Remove the HarfBuzz-old code : [Attachment 184984] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Dominik Röttsches (drott)
<dominik.rottsches at intel.com>'s request for review:
Bug 108077: [HarfBuzz] Remove the HarfBuzz-old code
https://bugs.webkit.org/show_bug.cgi?id=108077

Attachment 184984: Patch
https://bugs.webkit.org/attachment.cgi?id=184984&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184984&action=review


Thanks for cleaning WebCore!

Please give some time for responses on webkit-dev before landing, EWS do not
cover everyone unfortunately.

> Source/WebCore/ChangeLog:17
> +	   (FontPlatformData): Removing USE(HARFBUZZ_NG) ifdef's.

"ifdef's"?
I have the feeling "ifdefs" is a more common notation(?).

Ditto * 4.

> Source/WebCore/platform/graphics/freetype/FontPlatformData.h:68
>      HarfBuzzNGFace* harfbuzzFace() const;

Shouldn't this be harfBuzzFace()?

> Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:-43
> -#if USE(HARFBUZZ_NG)
>  #include "HarfBuzzNGFace.h"
> -#else

You keep that header unsorted?

> Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:51
>  class FontDescription;
>  
> -#if USE(HARFBUZZ_NG)
>  class HarfBuzzNGFace;

Move the declarations together.

> Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:111
>      HarfBuzzNGFace* harfbuzzFace() const;

Shouldn't this be harfBuzzFace()?