[webkit-reviews] review canceled: [Bug 108139] Upstream iOS's AtomicString : [Attachment 185123] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has canceled Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 108139: Upstream iOS's AtomicString
https://bugs.webkit.org/show_bug.cgi?id=108139

Attachment 185123: Patch
https://bugs.webkit.org/attachment.cgi?id=185123&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
> > Source/WTF/wtf/text/AtomicString.cpp:44
> > +#if PLATFORM(IOS)
> 
> I would like this to be a check for something more specific.	Maybe
USE(WEB_THREAD)

I like that idea.

> > Source/WTF/wtf/text/AtomicString.cpp:121
> > +#if PLATFORM(IOS)
> > +	 AtomicStringTableLocker locker;
> > +#endif
> 
> Instead of having all these #ifdefs at the call site, could we just make
those without a WebThread have an empty implementation of
AtomicStringTableLocker?

I am afraid someone will misunderstand what it is and use
AtomicStringTableLocker at a bad place. With the #ifdef, it is clear you should
not touch that if not for iOS.