[webkit-reviews] review granted: [Bug 106608] [v8] Security feature: JavaScript Bindings hardening : [Attachment 185118] Patch, specify exceptions in IDL files.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Thomas Sepez <tsepez at chromium.org>'s
request for review:
Bug 106608: [v8] Security feature: JavaScript Bindings hardening
https://bugs.webkit.org/show_bug.cgi?id=106608

Attachment 185118: Patch, specify exceptions in IDL files.
https://bugs.webkit.org/attachment.cgi?id=185118&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185118&action=review


This looks much better.  Thank you for pushing this data out into IDL
attributes.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3603
> +sub GetGnuVTableOffsetForType

I probably would have added a FIXME or a comment explaining this function.

> Source/WebCore/css/WebKitCSSFilterValue.idl:30
>	   Conditional=CSS_FILTERS,
>	   IndexedGetter,
> -	   DoNotCheckConstants
> +	   DoNotCheckConstants,
> +    ImplementationLacksVTable

Looks like there are some indent issues.  It would be nice to clean up the bad
indents to match the four-space indent, but we can do that in a followup patch.


> Source/WebKit/chromium/features.gypi:37
> +	 'ENABLE_BINDING_INTEGRITY=0',

Did you mean to land the patch with this disabled?  I guess we can flip the
switch separately from the big code edit.