[webkit-reviews] review granted: [Bug 108110] [CSS Grid Layout] Make resolveContentBasedTrackSizingFunctionsForItems reuse distributeSpaceToTracks : [Attachment 185069] Proposed refactoring #1: change distributeSpaceToTracks arguments to match intent and allow for more sharing.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 28 16:47:27 PST 2013


Tony Chang <tony at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 108110: [CSS Grid Layout] Make
resolveContentBasedTrackSizingFunctionsForItems reuse distributeSpaceToTracks
https://bugs.webkit.org/show_bug.cgi?id=108110

Attachment 185069: Proposed refactoring #1: change distributeSpaceToTracks
arguments to match intent and allow for more sharing.
https://bugs.webkit.org/attachment.cgi?id=185069&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
I think this is OK, but it's very confusing who mutates GridTracks and who
doesn't.  Using a mix of Vector<GridTrack> and Vector<GridTrack*> makes things
more confusing.


More information about the webkit-reviews mailing list