[webkit-reviews] review granted: [Bug 107198] [TexMap] Enable debug borders and repaint counter via Settings. : [Attachment 185073] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 107198: [TexMap] Enable debug borders and repaint counter via Settings.
https://bugs.webkit.org/show_bug.cgi?id=107198

Attachment 185073: Patch
https://bugs.webkit.org/attachment.cgi?id=185073&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185073&action=review


In which patch are the getenv() removed from CoordinatedBackingStore?

Some comments, no need to fix those:

> Source/WebKit/efl/ewk/ewk_view.cpp:842
> +    char* debugVisualsEnvironment =
getenv("WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS");

const char*

> Source/WebKit/gtk/webkit/webkitwebview.cpp:3439
> +    char* debugVisualsEnvironment =
getenv("WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS");

Ditto.

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:152
> +    char* debugVisualsEnvironment =
getenv("WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS");

Ditto.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:263
> +	       char* debugVisualsEnvironment =
getenv("WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS");

Ditto.