[webkit-reviews] review granted: [Bug 108116] Handle createShadowSubtree inside of ensureUserAgentShadowRoot : [Attachment 185065] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 108116: Handle createShadowSubtree inside of ensureUserAgentShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=108116

Attachment 185065: Patch
https://bugs.webkit.org/attachment.cgi?id=185065&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185065&action=review


Lovely.

> Source/WebCore/dom/Element.cpp:1495
> +    ShadowRoot* shadowRoot = ShadowRoot::create(this,
ShadowRoot::UserAgentShadowRoot, ASSERT_NO_EXCEPTION).get();

Ugh, we should totally get rid of this nasty factory. It just looks bad,
handing off a PassRefPtr to immediately get it unwrapped.