[webkit-reviews] review granted: [Bug 107975] Don't use the threaded HTML parser for javascript: URLs : [Attachment 185009] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 28 11:07:31 PST 2013


Adam Barth <abarth at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 107975: Don't use the threaded HTML parser for javascript: URLs
https://bugs.webkit.org/show_bug.cgi?id=107975

Attachment 185009: Patch
https://bugs.webkit.org/attachment.cgi?id=185009&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185009&action=review


> Source/WebCore/html/parser/HTMLParserOptions.cpp:44
> -    useThreading = settings && settings->threadedHTMLParser();
> +    useThreading = settings && settings->threadedHTMLParser() && (!document
|| !document->url().isBlankURL());

settings being non-zero implies that document is non-zero, so you can remove
the check for !document.


More information about the webkit-reviews mailing list