[webkit-reviews] review granted: [Bug 107538] [GTK] [WTR] layoutTestController.pathToLocalResource needs to be updated : [Attachment 183953] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 28 07:33:10 PST 2013
Martin Robinson <mrobinson at webkit.org> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 107538: [GTK] [WTR] layoutTestController.pathToLocalResource needs to be
updated
https://bugs.webkit.org/show_bug.cgi?id=107538
Attachment 183953: Patch
https://bugs.webkit.org/attachment.cgi?id=183953&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183953&action=review
Nice work. This looks good to me. I have just pointed out a style nit below. If
you like, I can fix this and land it or you can upload a new patch.
> Tools/WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:35
> #include "InjectedBundle.h"
> +
> +#include "InjectedBundleUtilities.h"
> +
> #include <glib.h>
> +#include <wtf/gobject/GOwnPtr.h>
Keep all these includes together as one solid block.
More information about the webkit-reviews
mailing list