[webkit-reviews] review denied: [Bug 105285] Web Inspector: [Styles] Implement navigation to UI locations of property names/values in the source code : [Attachment 184966] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 105285: Web Inspector: [Styles] Implement navigation to UI locations of
property names/values in the source code
https://bugs.webkit.org/show_bug.cgi?id=105285

Attachment 184966: Patch
https://bugs.webkit.org/attachment.cgi?id=184966&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184966&action=review


I think we should split this into 2 separate changes - one for sass source maps
and another one for UI feature.
It would be great to have a test for SASS source mappings also.

> Source/WebCore/inspector/front-end/SASSSourceMapping.js:201
> +	   sourceMapURL =
WebInspector.SourceMap.prototype._canonicalizeURL(sourceMapURL, styleSheetURL);


https://bugs.webkit.org/show_bug.cgi?id=107939 removes _canonicalizeURL and
uses completeURL instead.
You will need to update your patch to follow this way of resolving relative
URLs.