[webkit-reviews] review granted: [Bug 107939] Web Inspector: SourceURL and SourceMappingURL together in evalled code : [Attachment 184946] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 107939: Web Inspector: SourceURL and SourceMappingURL together in evalled
code
https://bugs.webkit.org/show_bug.cgi?id=107939

Attachment 184946: Patch
https://bugs.webkit.org/attachment.cgi?id=184946&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184946&action=review


> Source/WebCore/inspector/front-end/CompilerScriptMapping.js:97
> +	   if (!sourceMap)

I like this. The reason it was not here before is that it is currently done in
WebInspector.DebuggerScriptMapping. I think we should remove the check there
and move it here.

> Source/WebCore/inspector/front-end/CompilerScriptMapping.js:178
> +	       var baseURL = sourceMapURL.startsWith("data:") ? scriptURL :
sourceMapURL;

You could use ParsedURL.isDataURL() instead.