[webkit-reviews] review denied: [Bug 107552] Web Inspector: Show element style panes in a tabbed pane when they are below the DOM tree pane. : [Attachment 184758] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vladislav Kaznacheev
<kaznacheev at chromium.org>'s request for review:
Bug 107552: Web Inspector: Show element style panes in a tabbed pane when they
are below the DOM tree pane.
https://bugs.webkit.org/show_bug.cgi?id=107552

Attachment 184758: Patch
https://bugs.webkit.org/attachment.cgi?id=184758&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184758&action=review


> Source/WebCore/ChangeLog:8
> +	   Made WebInspector.SidebarPane extend WebInspector.View.

Sounds like a separate change. Please extract it.

> Source/WebCore/inspector/front-end/SidebarView.js:141
> +    _getEffectiveSidebarPosition: function(sidebarPosition)

no get prefixes in getters please