[webkit-reviews] review denied: [Bug 107944] Web Inspector: implmenet Ctrl-Arrow/Ctrl-Backspace in DefaultTextEditor : [Attachment 184754] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 107944: Web Inspector: implmenet Ctrl-Arrow/Ctrl-Backspace in
DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=107944

Attachment 184754: Patch
https://bugs.webkit.org/attachment.cgi?id=184754&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184754&action=review


> Source/WebCore/inspector/front-end/DefaultTextEditor.js:417
> +	  
this._shortcuts[WebInspector.KeyboardShortcut.makeKey(keys.Right.code,
modifiers.Ctrl)] = this._handleCtrlArrow.bind(this, "right");

It would be great if we could extract these into a common 'controller' subclass
(located in the same file).

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:434
> +	       var charCode = char.charCodeAt(0);

lets use string comparizon

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:454
> +	   if (column === -1 && direction === "left") {

growRangeLeft/Right