[webkit-reviews] review granted: [Bug 107940] Web Inspector: remove unused isElement and similar methods from HeapProfiler : [Attachment 184734] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 107940: Web Inspector: remove unused isElement and similar methods from
HeapProfiler
https://bugs.webkit.org/show_bug.cgi?id=107940

Attachment 184734: Patch
https://bugs.webkit.org/attachment.cgi?id=184734&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184734&action=review


> Source/WebCore/inspector/front-end/JSHeapSnapshot.js:74
> +	   return function(edge) {

{ on a separate line.
Maybe rewrite like this:
function funcName(...)
{
 ... 
}

return funcName;

> Source/WebCore/inspector/front-end/JSHeapSnapshot.js:78
> +		   return true

;