[webkit-reviews] review granted: [Bug 108035] [EFL][WK2] Rely more on C API in ewk_favicon_database : [Attachment 184918] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 108035: [EFL][WK2] Rely more on C API in ewk_favicon_database
https://bugs.webkit.org/show_bug.cgi?id=108035

Attachment 184918: Patch
https://bugs.webkit.org/attachment.cgi?id=184918&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
I am not entirely convinced this is necessary.

For port specific API, there is no need to force a C API between public APIs
and Proxys (in my opinion). If GTK were to use the new,
WKIconDatabaseTryGetCairoSurfaceForURL, then this would be helping consolidate
WebKit2.

I r+ because the patch seems correct and you handle your port abstractions as
you see fit.