[webkit-reviews] review requested: [Bug 91440] Implement 'vmin' and 'vmax' from CSS3 values and units : [Attachment 184907] Proposed patch

[bugzilla-daemon at webkit.org]

Uday Kiran <udaykiran at motorola.com> has asked  for review:
Bug 91440: Implement 'vmin' and 'vmax' from CSS3 values and units
https://bugs.webkit.org/show_bug.cgi?id=91440

Attachment 184907: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=184907&action=review

------- Additional Comments from Uday Kiran <udaykiran at motorola.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=184907&action=review


>> Source/WebCore/css/CSSParser.cpp:1642
>> +	       || (value->unit >= CSSPrimitiveValue::CSS_VW && value->unit <=
CSSPrimitiveValue::CSS_VMAX)
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent? 
[whitespace/indent] [3]

Should I fix this?

>> Source/WebCore/css/CSSParser.cpp:1647
>> +	       || (value->unit >= CSSPrimitiveValue::CSS_VW && value->unit <=
CSSPrimitiveValue::CSS_VMAX));
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent? 
[whitespace/indent] [3]

Ditto.