[webkit-reviews] review granted: [Bug 108009] The notification constructor needs to check permissions synchronously : [Attachment 184882] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 108009: The notification constructor needs to check permissions
synchronously
https://bugs.webkit.org/show_bug.cgi?id=108009

Attachment 184882: Patch
https://bugs.webkit.org/attachment.cgi?id=184882&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184882&action=review


>
LayoutTests/fast/notifications/notifications-constructor-with-permission.html:2
5
> +	       setTimeout(function() { testRunner.notifyDone(); }, 100);

This isn't flaky because the timer gets scheduled first, right?