[webkit-reviews] review granted: [Bug 107509] [Mac] Update PageVisibilityState when WebView is hidden / visible : [Attachment 184636] [PATCH] Addressed Review Comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jan 26 11:51:13 PST 2013
Sam Weinig <sam at webkit.org> has granted Joseph Pecoraro <joepeck at webkit.org>'s
request for review:
Bug 107509: [Mac] Update PageVisibilityState when WebView is hidden / visible
https://bugs.webkit.org/show_bug.cgi?id=107509
Attachment 184636: [PATCH] Addressed Review Comments
https://bugs.webkit.org/attachment.cgi?id=184636&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184636&action=review
> Tools/TestWebKitAPI/mac/WebKitAgnosticTest.h:62
> + virtual void deinitializeView(WebView *) { }
> + virtual void deinitializeView(WKView *) { }
I'm not a fan of this made up word. I would prefer cleanupView().
More information about the webkit-reviews
mailing list