[webkit-reviews] review granted: [Bug 107863] Makefiles should work for arbitrary SDKs and architectures on Apple ports : [Attachment 184833] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 107863: Makefiles should work for arbitrary SDKs and architectures on Apple
ports
https://bugs.webkit.org/show_bug.cgi?id=107863

Attachment 184833: Patch
https://bugs.webkit.org/attachment.cgi?id=184833&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184833&action=review


r=me

> Source/Makefile:3
> +IOS_DONT_BUILD = WebKit2

Nit: IOS_DO_NOT_BUILD would probably read a bit better.

> Tools/Makefile:4
> +IOS_DONT_BUILD = WebKitTestRunner MiniBrowser TestWebKitAPI
> +IPHONEOS_DONT_BUILD = DumpRenderTree

Ditto on s/DONT/DO_NOT/.