[webkit-reviews] review requested: [Bug 107397] [Efl][WebGL] Add better support to track and free XResources. : [Attachment 184862] patchv5
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jan 26 07:01:24 PST 2013
Kalyan <kalyan.kondapally at intel.com> has asked for review:
Bug 107397: [Efl][WebGL] Add better support to track and free XResources.
https://bugs.webkit.org/show_bug.cgi?id=107397
Attachment 184862: patchv5
https://bugs.webkit.org/attachment.cgi?id=184862&action=review
------- Additional Comments from Kalyan <kalyan.kondapally at intel.com>
Changed name of ScopedXResource to ScopedPtrX11 and moved it to a separate
header. Cannot use OwnPtr here with GLXFBConfig, as it is a pointer.
i.e it is defined as typedef struct __GLXFBConfigRec *GLXFBConfig. One way
would have been to handle this case separately but as we would need this change
(ScopedPtrX11) for it, so I let it manage all the X Resources.
More information about the webkit-reviews
mailing list