[webkit-reviews] review canceled: [Bug 107988] [Mac] Pixel-based tests are run in a computationally inefficient way : [Attachment 184840] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has canceled Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 107988: [Mac] Pixel-based tests are run in a computationally inefficient
way
https://bugs.webkit.org/show_bug.cgi?id=107988

Attachment 184840: Patch
https://bugs.webkit.org/attachment.cgi?id=184840&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Taking this out of the queue.
On my laptop, this makes the tests run slower than the old code. The reason is
the overhead of transferring more bytes is higher than the cost of compressing
the image (the speed of the RAM and smaller CPU caches likely explain why it
varies).

A solution to that would be to use shared memory instead of transferring
everything over a pipe.
Python and new-run-webkit-test have their load of problems, I am not sure what
to do :(