[webkit-reviews] review denied: [Bug 107987] Make unload-reparent-sibling-frame.html wait for completion : [Attachment 184819] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 107987: Make unload-reparent-sibling-frame.html wait for completion
https://bugs.webkit.org/show_bug.cgi?id=107987

Attachment 184819: Patch
https://bugs.webkit.org/attachment.cgi?id=184819&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184819&action=review


This is kind of changing what this test is testing, no? As in, it used to also
test that we'd fire the onload events for both frames when they're reparented
and the description seems to be that it's explicitly testing that. Adding
waituntildone/notifydone makes sense, but I think you need to notifyDone in teh
onload handlers.

> LayoutTests/fast/frames/unload-reparent-sibling-frame.html:40
> +	       isSuccessfullyParsed();

Ideally you'd include js-test-post.js. That ensures that the test doesn't
appear to pass if you accidentally introduce a JS error. I don't think this
actually does what it's intended to if don't include js-test-post.js (i.e. it's
supposed to spit out an error if it's not successfully parsed.