[webkit-reviews] review granted: [Bug 107966] Don't subtract too much from nonSilentFramesToProcess : [Attachment 184800] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Raymond Toy <rtoy at chromium.org>'s
request for review:
Bug 107966: Don't subtract too much from nonSilentFramesToProcess
https://bugs.webkit.org/show_bug.cgi?id=107966

Attachment 184800: Patch
https://bugs.webkit.org/attachment.cgi?id=184800&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=184800&action=review


Looks fine. Couple of minor comments.

> Source/WebCore/ChangeLog:6
> +	   Reviewed by NOBODY.

Is that line hand-written? If so I don't think it's going to be auto-replaced
by the commit queue.

> Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:123
> +		   nonSilentFramesToProcess -= framesToZero;

Wow, awful. How about an ASSERT that nonSilentFramesToProcess >= 0 then?