[webkit-reviews] review denied: [Bug 107494] Add window occlusion criteria to determine page visibility on Mac : [Attachment 184794] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 25 14:07:18 PST 2013
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Kiran Muppala
<cmuppala at apple.com>'s request for review:
Bug 107494: Add window occlusion criteria to determine page visibility on Mac
https://bugs.webkit.org/show_bug.cgi?id=107494
Attachment 184794: Patch
https://bugs.webkit.org/attachment.cgi?id=184794&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=184794&action=review
> Source/WebKit2/UIProcess/API/mac/WKView.mm:276
> + [[WKView _allViews] removeObject:self];
This will never get hit. -allViews retains, so you'll never hit this dealloc.
More information about the webkit-reviews
mailing list