[webkit-reviews] review requested: [Bug 106815] [Chromium] Tests and fixes for spell checker behavior : [Attachment 184808] Proposed patch

[bugzilla-daemon at webkit.org]

Rouslan Solomakhin <rouslan+webkit at chromium.org> has asked  for review:
Bug 106815: [Chromium] Tests and fixes for spell checker behavior
https://bugs.webkit.org/show_bug.cgi?id=106815

Attachment 184808: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=184808&action=review

------- Additional Comments from Rouslan Solomakhin
<rouslan+webkit at chromium.org>
Added Changelog.
Added description of how to test manually.
Added setSelectTrailingWhitespaceEnabled and setSmartInsertDeleteEnabled in all
tests.
Removed unnecessary test cleanup calls.

Tony: Thank you for the review. I've placed the tests in
platform/chromium/editing/spelling because I am testing and fixing the behavior
of Source/WebKit/chromium/src/ContextMenuClientImpl.cpp specifically. Chromium
spell check behaves differently from other WebKit ports. For example, Chromium
selects the misspelled word on context click, but Safari does not.

Calls to setSelectTrailingWhitespaceEnabled should be necessary only when
double-clicks are involved, but I've put it in all the tests for good measure.

Calls to setSmartInsertDeleteEnabled should be necessary only when we test
replacing the misspelling with a suggestion. These tests do not exercise that
functionality, but I've put it in all the tests for good measure, too.