[webkit-reviews] review granted: [Bug 104829] Introduce a mechanism to run a task before layout and migrate RenderCounter to using it : [Attachment 182883] Patch v5: Rebaselined for the EWS.

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 104829: Introduce a mechanism to run a task before layout and migrate
RenderCounter to using it
https://bugs.webkit.org/show_bug.cgi?id=104829

Attachment 182883: Patch v5: Rebaselined for the EWS.
https://bugs.webkit.org/attachment.cgi?id=182883&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182883&action=review


Lets use the ListHashSet for deterministic order in traversal and predictable
failures.

> Source/WebCore/rendering/RenderView.cpp:218
> +	   m_preLayoutTreeMutatingTasks = adoptPtr(new
HashSet<RenderObject*>());

Don't we have a typedef for ListHashSet<RenderObject*> ?