[webkit-reviews] review denied: [Bug 105642] Dubious cast from TextTrackCueBox to HTMLDivElement. : [Attachment 184771] Trivial fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 25 10:45:48 PST 2013
Ryosuke Niwa <rniwa at webkit.org> has denied Victor Carbune
<vcarbune at chromium.org>'s request for review:
Bug 105642: Dubious cast from TextTrackCueBox to HTMLDivElement.
https://bugs.webkit.org/show_bug.cgi?id=105642
Attachment 184771: Trivial fix
https://bugs.webkit.org/attachment.cgi?id=184771&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184771&action=review
> Source/WebCore/ChangeLog:8
> + Trivial change.
Please explain why we're making this change. r- due to the lack of explanation.
> Source/WebCore/html/track/TextTrackCue.cpp:99
> - : HTMLElement(divTag, document)
> + : HTMLDivElement(divTag, document)
Why are we making this change? Does the spec say we should do this? If not, why
should we do this?
More information about the webkit-reviews
mailing list