[webkit-reviews] review granted: [Bug 107890] Add a user agent stylesheet for plugins : [Attachment 184766] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 25 10:03:53 PST 2013
Alexey Proskuryakov <ap at webkit.org> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 107890: Add a user agent stylesheet for plugins
https://bugs.webkit.org/show_bug.cgi?id=107890
Attachment 184766: Patch
https://bugs.webkit.org/attachment.cgi?id=184766&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> I was confused because the other methods in this class that return Strings
adopt the result of toImpl - generateFileForUpload and
shouldGenerateFileForUpload, even without "copy" or "create" in the name. I've
removed it.
I don't know which is correct, but it would be easy to tell from checking the
code, or stepping through it. Seems likely that there is something to fix here,
if only naming.
More information about the webkit-reviews
mailing list