[webkit-reviews] review denied: [Bug 107651] Add an API for retrieving native memory information without going through the remote inspecting protocol : [Attachment 184701] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Marja Hölttä
<marja at chromium.org>'s request for review:
Bug 107651: Add an API for retrieving native memory information without going
through the remote inspecting protocol
https://bugs.webkit.org/show_bug.cgi?id=107651

Attachment 184701: Patch
https://bugs.webkit.org/attachment.cgi?id=184701&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184701&action=review


Can you do InspectorMemoryAgent refactorings in a separate change?

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:88
> +	   m_sizesMap = sizesMap;

m_sizesMap should be a pointer or a reference, otherwise passed sizesMap will
remain unchanged.

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:645
> +    return memoryInfoVector;

You can pass reference to WebVector<WebMemoryUsageInfo> as a parameter to avoid
potential extra copies, the same for hash map returned by
getProcessMemoryDistribution.