[webkit-reviews] review granted: [Bug 85244] Disabled input/textarea doesn't trigger selection change : [Attachment 184678] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 24 23:23:29 PST 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 85244: Disabled input/textarea doesn't trigger selection change
https://bugs.webkit.org/show_bug.cgi?id=85244

Attachment 184678: Patch
https://bugs.webkit.org/attachment.cgi?id=184678&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184678&action=review


Makes sense.

> LayoutTests/fast/forms/input-readonly-select.html:38
> +input.addEventListener('select', function() {
> +    selectEventFiredOnInput = true;
> +});

Should we also check selectstart and selectionchange events?


More information about the webkit-reviews mailing list