[webkit-reviews] review granted: [Bug 107918] INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum() and maximum() of DateTimeSymbolicFieldElement : [Attachment 184675] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 107918: INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum()
and maximum() of DateTimeSymbolicFieldElement
https://bugs.webkit.org/show_bug.cgi?id=107918

Attachment 184675: Patch
https://bugs.webkit.org/attachment.cgi?id=184675&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184675&action=review


Looks OK.

> Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:97
> +    DateTimeFieldElement::initialize(pseudo, axHelpText, m_minimumIndex + 1,
m_maximumIndex + 1);

You might want to add a comment why you are passing +1 values (if you want).
That looks mysterious to strangers.