[webkit-reviews] review denied: [Bug 107813] Web Inspector: Filters on Console panel : [Attachment 184499] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Dmitry Zvorygin
<zvorygin at chromium.org>'s request for review:
Bug 107813: Web Inspector: Filters on Console panel
https://bugs.webkit.org/show_bug.cgi?id=107813

Attachment 184499: Patch
https://bugs.webkit.org/attachment.cgi?id=184499&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184499&action=review


A bunch of really minor style nits and a request for test.

> Source/WebCore/inspector/front-end/ConsoleView.js:459
> +	   var srcElement =
event.target.enclosingNodeOrSelfWithClass("console-message");

style: WebKit discourages usage of abbreviated strings. Should be
sourceElement.

> Source/WebCore/inspector/front-end/ConsoleView.js:461
> +	   var filterSubMenu = contextMenu.appendSubMenuItem("Filter",
!(this._messageURLFilters.length || (srcElement && srcElement.message.url)));

UIString("Filter")

> Source/WebCore/inspector/front-end/ConsoleView.js:471
> +	       filterSubMenu.appendCheckboxItem(new
WebInspector.ParsedURL(this._messageURLFilters[i]).displayName + " (" +
this._urlToMessageCount[this._messageURLFilters[i]] + ")",
this._removeMessageUrlFilter.bind(this, i), true);

You could use message format: String.sprintf("%s (%d)", displayName, count)

> Source/WebCore/inspector/front-end/ConsoleView.js:502
> +	   if (idx == -1)

index (no abbreviations)

> Source/WebCore/inspector/front-end/ConsoleView.js:515
> +    _shouldBeVisible: function(msg)

message

> Source/WebCore/inspector/front-end/ConsoleView.js:520
> +    _updateMessageList: function()

A test?

> Source/WebCore/inspector/front-end/ConsoleView.js:811
> +		   this.messagesElement.insertBefore(element, node);

insertBefore(element, null) would work as appendChild and just as fast (see
ContainerNode.cpp:241), no need to fork the code here.