[webkit-reviews] review granted: [Bug 107829] Web Inspector: support JavaScript variable mutation in protocol and V8 bindings : [Attachment 184524] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 107829: Web Inspector: support JavaScript variable mutation in protocol and
V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=107829

Attachment 184524: Patch
https://bugs.webkit.org/attachment.cgi?id=184524&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184524&action=review


> Source/WebCore/bindings/v8/DebuggerScript.js:99
> +    if (!mirror.isFunction()) {

nit: no need for {}

> Source/WebCore/bindings/v8/DebuggerScript.js:108
> +    if (!scopeMirror) {

ditto

> Source/WebCore/inspector/InjectedScriptSource.js:434
> +		       return String(e);

return e.toString()

> Source/WebCore/inspector/InjectedScriptSource.js:624
> +	       return String(e);

ditto